• fix(pegboard): cache none runner pool errors too #3899
• fix(engine-runner): handle shutdown close codes correctly #3896
• chore(gas): add overview and history docs #3879
• fix(otel): enrich http traces #3878
• fix(guard): clean up guard #3862
• fix: add ready_chunks to worker bumps, bumps per tick metric #3855
• fix(epoxy): add metrics #3847
• chore: clean up errors #3846 👈 (View in Graphite)
• fix(pb): have restart policy actors sleep after pending for too long #3837
• fix: set failure reason regardless of crash policy #3835
• feat: add metrics to pb, guard #3815
• fix: clear all pending signals after workflow complete #3798
• fix: remove pending actors metric, fix actor error tracker, engine runner error print #3797
• chore(engine): add support for epoxy debugging #3794
• main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

PR Review: Clean up errors

Summary

This PR consolidates error definitions by:

1. Moving the Datacenter::NotFound error from api-public to api-util for better code reuse
2. Removing unused guard errors (actor_destroyed, actor_not_found)
3. Renaming test error artifacts to use test group with combined group+code names
4. Improving error handling in guard-core tests

Code Quality ✅

Good practices observed:

• Proper error consolidation - moving Datacenter::NotFound to api-util follows DRY principles since it's used by multiple packages
• Making errors module public (pub mod errors;) enables proper reuse across packages
• Test error artifacts correctly renamed to avoid confusion with production errors
• Clean removal of unused error definitions

Implementation Review

1. Error Migration (api-util/api-public) ✅

The Datacenter::NotFound error migration is well-executed:

• Moved from api-public/src/errors.rs to api-util/src/errors.rs
• Updated all references in:
  • packages/api-public/src/actors/utils.rs:144
  • packages/api-public/src/runner_configs/upsert.rs:99
• The error is used in api-util/src/lib.rs (lines 36, 74), justifying its location

2. Unused Error Cleanup ✅

Removal of unused guard errors is appropriate:

• guard.actor_destroyed.json
• guard.actor_not_found.json

These appear to be legitimately unused. If they were referenced anywhere, the build would fail.

3. Test Error Artifacts ✅

Renaming test errors improves clarity:

• api.rate_limited.json → test.api_rate_limited.json
• namespace.invalid_name.json → test.namespace_invalid_name.json

This prevents confusion between test fixtures and production error definitions. The corresponding test updates in engine/packages/error/tests/basic.rs maintain consistency.

4. Guard Test Improvements ✅

The changes in guard-core/tests/streaming_response.rs improve code quality:

• Early return pattern (return Ok(...)) is clearer than assigning to a variable
• Using anyhow::anyhow!("bad path") instead of bail!("bad path") is more idiomatic when not using the bail! macro's shorthand benefits
• However, the original code with bail! was also fine - this is a minor style preference

Minor consideration: The change from bail! to anyhow::anyhow! removes the use anyhow::bail; import. While both work correctly, bail! is typically preferred for simple error messages as it's more concise. This is a very minor point and doesn't affect functionality.

Potential Issues

No issues found. All changes are backward compatible and properly implemented.

Performance Considerations ✅

No performance impact. This is a refactoring/cleanup PR with no runtime changes.

Security Considerations ✅

No security concerns. Error handling remains unchanged functionally.

Test Coverage ✅

Test coverage is maintained:

• Test files updated to reflect renamed error artifacts
• No functionality changes that would require new tests
• Existing tests validate the error system works correctly

Adherence to CLAUDE.md Guidelines ✅

• ✅ Error definitions follow the documented pattern with #[derive(RivetError)]
• ✅ Error groups properly categorized ("datacenter", "test", "validation")
• ✅ Proper use of workspace dependencies
• ✅ No backwards-compatibility hacks

Recommendations

All changes look good! This is a clean refactoring PR that:

1. Reduces code duplication
2. Improves error organization
3. Removes unused code
4. Clarifies test vs. production errors

The PR is ready to merge. No action items required.

Minor Note (optional, not blocking)

In guard-core/tests/streaming_response.rs:256, the switch from bail! to anyhow::anyhow! is functionally equivalent. If you want to maintain consistency with other error handling in the codebase, bail!("bad path") is slightly more idiomatic for simple error messages, but the current implementation is perfectly fine.

Verdict: LGTM ✅ - Well-executed cleanup PR with no issues.

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3846

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3846

commit: 520df1b

Merge activity

• Jan 14, 11:40 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
• Jan 14, 11:41 PM UTC: CI is running for this pull request on a draft pull request (#3908) due to your merge queue CI optimization settings.
• Jan 14, 11:42 PM UTC: Merged by the Graphite merge queue via draft PR: #3908.